uranusjr commented on code in PR #40868:
URL: https://github.com/apache/airflow/pull/40868#discussion_r1687819158
##########
airflow/datasets/__init__.py:
##########
@@ -271,6 +306,20 @@ def iter_datasets(self) -> Iterator[tuple[str, Dataset]]:
yield k, v
seen.add(k)
+ def iter_dag_deps(self, *, source: str, target: str) ->
Iterator[DagDependency]:
+ """
+ Iterate dataset, dataset aliases and their resolved datasets as dag
dependency.
+
+ :meta private:
+ """
+ dag_deps: set[DagDependency] = set()
Review Comment:
By “now” above you mean before this PR right? That’s what I would expect the
graph to look like. So we still need some dedup logic when rendering the UI,
regardless what we do in all/any. But I want those to be strictly in the UI
layer (i.e. somewhere in API or frontend), not `iter_dag_dependencies`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
