potiuk commented on code in PR #41109:
URL: https://github.com/apache/airflow/pull/41109#discussion_r1696285950
##########
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##########
@@ -694,8 +694,9 @@ def _adopt_completed_pods(self, kube_client:
client.CoreV1Api) -> None:
)
except ApiException as e:
self.log.info("Failed to adopt pod %s. Reason: %s",
pod.metadata.name, e)
- ti_id = annotations_to_key(pod.metadata.annotations)
- self.running.add(ti_id)
+ else:
Review Comment:
Nit: Is there a way maybe to distinguish temporary from permanent
exceptions? I do not know the API well - but this one calls for (if transient
-> retry) case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
