jedcunningham commented on code in PR #41109:
URL: https://github.com/apache/airflow/pull/41109#discussion_r1696900146
##########
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##########
@@ -694,8 +694,9 @@ def _adopt_completed_pods(self, kube_client:
client.CoreV1Api) -> None:
)
except ApiException as e:
self.log.info("Failed to adopt pod %s. Reason: %s",
pod.metadata.name, e)
- ti_id = annotations_to_key(pod.metadata.annotations)
- self.running.add(ti_id)
+ else:
Review Comment:
Even if it is transient, there isn't much harm in just waiting until the
next cycle to try adopting it again.
There isn't a robust way to know if its transient, afaik. You can approach
it like
[this](https://github.com/apache/airflow/blob/41508f23ad87bdf410978ff96e62d8057d17d9d0/airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py#L411),
but I don't think it's worth it in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
