wolfier commented on code in PR #41109:
URL: https://github.com/apache/airflow/pull/41109#discussion_r1696354408
##########
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##########
@@ -694,8 +694,9 @@ def _adopt_completed_pods(self, kube_client:
client.CoreV1Api) -> None:
)
except ApiException as e:
self.log.info("Failed to adopt pod %s. Reason: %s",
pod.metadata.name, e)
- ti_id = annotations_to_key(pod.metadata.annotations)
- self.running.add(ti_id)
+ else:
Review Comment:
In
[adopt_launched_task](https://github.com/apache/airflow/blob/2.9.3/airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py#L671-L679),
the exception clause calls return.
```
try:
kube_client.patch_namespaced_pod(
name=pod.metadata.name,
namespace=pod.metadata.namespace,
body={"metadata": {"labels": {"airflow-worker":
new_worker_id_label}}},
)
except ApiException as e:
self.log.info("Failed to adopt pod %s. Reason: %s",
pod.metadata.name, e)
return
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
