perry2of5 commented on code in PR #41142:
URL: https://github.com/apache/airflow/pull/41142#discussion_r1702008503
##########
airflow/providers/microsoft/azure/operators/container_instances.py:
##########
@@ -86,6 +86,12 @@ class AzureContainerInstancesOperator(BaseOperator):
:param container_timeout: max time allowed for the execution of
the container instance.
:param tags: azure tags as dict of str:str
+ :param xcom_all: Control if logs are pushed to XCOM similarly to how
DockerOperator does.
Review Comment:
My goal isn't to look at the logs. My goal is to get the last line from
standard out and use it to determine if process succeeded or not. This is
exactly what the docker operator provides:
https://github.com/apache/airflow/blob/main/airflow/providers/docker/operators/docker.py#L142
Are you saying providing something similar to the way the docker operator
works is the wrong approach?
Perhaps I'm approaching this the wrong way entirely. I assume it is standard
to check if a process that ran externally succeeded or failed before
continuing. If so, what is the standard way to do this with docker, Azure
Container Instances, et cetera?
Thank you and sorry if I'm completely off base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
