potiuk commented on code in PR #41142:
URL: https://github.com/apache/airflow/pull/41142#discussion_r1702084177
##########
airflow/providers/microsoft/azure/operators/container_instances.py:
##########
@@ -86,6 +86,12 @@ class AzureContainerInstancesOperator(BaseOperator):
:param container_timeout: max time allowed for the execution of
the container instance.
:param tags: azure tags as dict of str:str
+ :param xcom_all: Control if logs are pushed to XCOM similarly to how
DockerOperator does.
Review Comment:
I agree this might be a useful feature actually - especially if it is an
opt-in. I don't see a fundamental problem with it - generally speaking - every
operator might decide what it wants to push to XCom. I am a little worried
though about pulling all logs even if you want to push just one last line -
unless there are are some smart generators implemented by the hook/library,
this one might be cause huge memory issues when the logs produced are large.
Is there any way you could optimize it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
