perry2of5 commented on code in PR #41142:
URL: https://github.com/apache/airflow/pull/41142#discussion_r1702101276
##########
airflow/providers/microsoft/azure/operators/container_instances.py:
##########
@@ -86,6 +86,12 @@ class AzureContainerInstancesOperator(BaseOperator):
:param container_timeout: max time allowed for the execution of
the container instance.
:param tags: azure tags as dict of str:str
+ :param xcom_all: Control if logs are pushed to XCOM similarly to how
DockerOperator does.
Review Comment:
This will be opt-in. It does not change the default logic or response at all.
The way the docker operator works, if you pass xcom_all = False only the
last line to standard out is placed in XCOM, but if xcom_all=True then all of
standard out is put in XCOM.
In this PR, I use the same logic as the docker operator but default the
argument to NONE. If xcom_all is NONE, then nothing is put in XCOM. Assuming
people don't set xcom_all, then this is a no-op (well, one if runs).
You can see the logic controlling this around line 316 of the operator in
the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
