RNHTTR commented on code in PR #40447:
URL: https://github.com/apache/airflow/pull/40447#discussion_r1702198558
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -301,7 +301,12 @@ def _read_grouped_logs(self):
return True
def _read(
- self, ti: TaskInstance, try_number: int, metadata: dict | None = None
+ self,
+ ti: TaskInstance,
+ try_number: int,
+ metadata: dict | None = None,
+ offset: int = 0,
Review Comment:
I would just leave the `es_task_handler` alone right now
##########
airflow/utils/log/file_task_handler.py:
##########
@@ -351,6 +351,8 @@ def _read(
ti: TaskInstance,
try_number: int,
metadata: dict[str, Any] | None = None,
+ offset: int = 0,
+ limit: int = 100,
Review Comment:
The defaults for these should be None, and by default there should be no
pagination. There should only be pagination when it's specifically configured.
##########
airflow/providers/redis/log/redis_task_handler.py:
##########
@@ -75,6 +75,8 @@ def _read(
ti: TaskInstance,
try_number: int,
metadata: dict[str, Any] | None = None,
+ offset: int = 0,
+ limit: int = 100,
Review Comment:
No need to change the redis_task_handler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
