RNHTTR commented on code in PR #40447:
URL: https://github.com/apache/airflow/pull/40447#discussion_r1706129914
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -301,7 +301,12 @@ def _read_grouped_logs(self):
return True
def _read(
- self, ti: TaskInstance, try_number: int, metadata: dict | None = None
+ self,
+ ti: TaskInstance,
+ try_number: int,
+ metadata: dict | None = None,
+ offset: int = 0,
Review Comment:
It has to be opt in, so if a user upgrades to the version of Airflow that
supports task log pagination, it mustn't break. Unless the logic is actually
implemented for logs served from ES, I think it'd break, so by default, there
should be no pagination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
