andyjianzhou commented on code in PR #40447:
URL: https://github.com/apache/airflow/pull/40447#discussion_r1704815417
##########
airflow/utils/log/file_task_handler.py:
##########
@@ -351,6 +351,8 @@ def _read(
ti: TaskInstance,
try_number: int,
metadata: dict[str, Any] | None = None,
+ offset: int = 0,
+ limit: int = 100,
Review Comment:
Ah, I see, so if they didn't configure it, there would be pagination? Would
a simple fix make them an optional parameter?If Null it'll ignore all the
pagination logic. Else it'll use these default values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
