shahar1 commented on PR #40936: URL: https://github.com/apache/airflow/pull/40936#issuecomment-2267080209
> > This can lead to errors such as triggering the on_success_callback. > > I think it would be useful if we can have a test that reproduce the problem then we can try to find solution for it more easily. > > > This is a breaking change. Also, when all task instances of a dagrun are in skipped state, the dagrun is successful. Given that, I think we should still allow the on_success_callback to run when a TI is skipped. See: https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/dag-run.html#dag-run-status > > The scope of the bug as I understand it is for on_success_callback on task level > The concern you raise is about on_success_callback on the dag level. > If we can differentiate between the two cases - maybe we can fix the bug without causing a breaking change? > +1, if there's a conflict regarding whether it's a bug or an expected behavior, I'd suggest adding a boolean flag to the operator that will activate the fix on will. We could discuss in the dev list what the default behavior should be, and if there's a concesus, negating the default (with a possible removal of the flag). What do you guys think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
