uranusjr commented on code in PR #40936:
URL: https://github.com/apache/airflow/pull/40936#discussion_r1703636683


##########
airflow/models/baseoperator.py:
##########
@@ -276,6 +276,7 @@ def partial(
     task_display_name: str | None | ArgNotSet = NOTSET,
     logger_name: str | None | ArgNotSet = NOTSET,
     allow_nested_operators: bool = True,
+    execute_on_success_callback_when_skipped: bool = True,

Review Comment:
   If we want to keep compatibility, shouldn’t think be False instead?
   
   Also since we’re not going to accept features on 2.x anyway, maybe we should 
just get rid of this argument entirely and always just run the callback?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to