romsharon98 commented on code in PR #40936:
URL: https://github.com/apache/airflow/pull/40936#discussion_r1704946129
##########
airflow/models/baseoperator.py:
##########
@@ -276,6 +276,7 @@ def partial(
task_display_name: str | None | ArgNotSet = NOTSET,
logger_name: str | None | ArgNotSet = NOTSET,
allow_nested_operators: bool = True,
+ execute_on_success_callback_when_skipped: bool = True,
Review Comment:
Today on_success_callback execute if task is skipped therefore it should be
True for compatibility.
Upon reconsideration, I'm not in favor of adding a parameter solely for
compatibility.
Logically, the `on_success_callback` shouldn't execute if the task is
skipped, so this should be the default behavior.
I agree with @ephraimbuddy that it constitutes a breaking change, albeit as
a bugfix.
Therefore, I'll mark this PR as a draft and plan to reopen it for Airflow 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
