romsharon98 commented on PR #41564: URL: https://github.com/apache/airflow/pull/41564#issuecomment-2308975222
> Interesting. The errors we see are very useful :). > > 1. examples are part of the documentation of "main" airflow" - and I am afraid they will have to remain as examples in "airflow" not moved to provider, especially because point 2)... > 2. the examples should be embedded and shown in airflow when "examples" are enabled - I think we should not (at least not now) to develop a mechanism to read examples for Airflow from providers. > 3. The tests should also mock the moved packages. > > ``` > <module 'airflow.sensors.time_delta' from '/usr/local/lib/python3.8/site-packages/airflow/sensors/time_delta.py'> does not have the attribute 'sleep' > FAILED tests/providers/standard/time/sensors/test_time_delta.py::TestTimeDeltaSensorAsync::test_wait_sensor[True] - AttributeError: <module 'airflow.sensors.time_delta' from '/u > ``` revert the example dags to be under `main` airflow. should I add a link in index.yaml for those example dags? also not sure but should I change somewhere in the code to tell that this provider is mandatory and will auto installed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
