jscheffl commented on code in PR #41695:
URL: https://github.com/apache/airflow/pull/41695#discussion_r1744611759
##########
airflow/models/dag.py:
##########
@@ -3603,7 +3603,7 @@ def dag(
is_paused_upon_creation: bool | None = None,
jinja_environment_kwargs: dict | None = None,
render_template_as_native_obj: bool = False,
- tags: list[str] | None = None,
+ tags: abc.Collection | None = None,
Review Comment:
+1
```suggestion
tags: abc.Collection[str] | None = None,
```
##########
airflow/models/dag.py:
##########
@@ -355,7 +355,7 @@ def _create_orm_dagrun(
"doc_md": str,
"is_paused_upon_creation": bool,
"render_template_as_native_obj": bool,
- "tags": list,
+ "tags": abc.Collection,
Review Comment:
This should be a bit more preceise
```suggestion
"tags": abc.Collection[str],
```
##########
airflow/models/dag.py:
##########
@@ -532,7 +532,7 @@ def __init__(
is_paused_upon_creation: bool | None = None,
jinja_environment_kwargs: dict | None = None,
render_template_as_native_obj: bool = False,
- tags: list[str] | None = None,
+ tags: abc.Collection | None = None,
Review Comment:
Here as well
```suggestion
tags: abc.Collection[str] | None = None,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
