pierrejeambrun commented on code in PR #42184:
URL: https://github.com/apache/airflow/pull/42184#discussion_r1758398553
##########
.pre-commit-config.yaml:
##########
@@ -1254,93 +1252,93 @@ repos:
entry: ./scripts/ci/pre_commit/mypy.py
files: ^dev/.*\.py$|^scripts/.*\.py$
require_serial: true
- additional_dependencies: ['rich>=12.4.4']
+ additional_dependencies: ["rich>=12.4.4"]
- id: mypy-dev
- stages: [ 'manual' ]
+ stages: ["manual"]
name: Run mypy for dev (manual)
language: python
entry: ./scripts/ci/pre_commit/mypy_folder.py dev
pass_filenames: false
files: ^.*\.py$
require_serial: true
- additional_dependencies: [ 'rich>=12.4.4' ]
+ additional_dependencies: ["rich>=12.4.4"]
- id: mypy-airflow
name: Run mypy for airflow
language: python
entry: ./scripts/ci/pre_commit/mypy.py --namespace-packages
files: \.py$
exclude:
^.*/.*_vendor/|^airflow/migrations|^airflow/providers|^dev|^scripts|^docs|^provider_packages|^tests/providers|^tests/system/providers|^tests/dags/test_imports.py|^clients/python/test_.*\.py
require_serial: true
- additional_dependencies: ['rich>=12.4.4']
+ additional_dependencies: ["rich>=12.4.4"]
- id: mypy-airflow
- stages: [ 'manual' ]
+ stages: ["manual"]
name: Run mypy for airflow (manual)
language: python
entry: ./scripts/ci/pre_commit/mypy_folder.py airflow
pass_filenames: false
files: ^.*\.py$
require_serial: true
- additional_dependencies: [ 'rich>=12.4.4' ]
+ additional_dependencies: ["rich>=12.4.4"]
- id: mypy-providers
name: Run mypy for providers
language: python
entry: ./scripts/ci/pre_commit/mypy.py --namespace-packages
files:
^airflow/providers/.*\.py$|^tests/providers/.*\.py$|^tests/system/providers/.*\.py$
exclude: ^.*/.*_vendor/
require_serial: true
- additional_dependencies: ['rich>=12.4.4']
+ additional_dependencies: ["rich>=12.4.4"]
- id: mypy-providers
- stages: ['manual']
+ stages: ["manual"]
name: Run mypy for providers (manual)
language: python
entry: ./scripts/ci/pre_commit/mypy_folder.py airflow/providers
pass_filenames: false
files: ^.*\.py$
require_serial: true
- additional_dependencies: ['rich>=12.4.4']
+ additional_dependencies: ["rich>=12.4.4"]
Review Comment:
Some vscode / IDE formatter ran on this file. The original form was
intended. Can we revert the formatting part ?
##########
.vscode/settings.json:
##########
@@ -0,0 +1,14 @@
+{
Review Comment:
Why are we committing a local editor config file ?
This is specific to each dev (some of them are not even using vscode), I
believe this should remain ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
