pierrejeambrun commented on code in PR #42184:
URL: https://github.com/apache/airflow/pull/42184#discussion_r1758452962


##########
airflow/ui/package.json:
##########
@@ -7,7 +7,7 @@
   "scripts": {
     "dev": "vite",
     "build": "tsc -b && vite build",
-    "lint": "eslint . && tsc --p tsconfig.app.json",
+    "lint": "eslint --quiet && tsc --p tsconfig.app.json",

Review Comment:
   Why do we want to suppress warnings in our editors ? I personally like to 
see them (we do have them for the backend/python part with ruff tough) 
   
   The fix step bellow `lint:fix` does not specify the `--quiet` does that mean 
that we actually check `warnings` for errors in the CI but our editor is 
omitting them ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to