loucyx commented on code in PR #42184:
URL: https://github.com/apache/airflow/pull/42184#discussion_r1758444854
##########
.pre-commit-config.yaml:
##########
@@ -1254,93 +1252,93 @@ repos:
entry: ./scripts/ci/pre_commit/mypy.py
files: ^dev/.*\.py$|^scripts/.*\.py$
require_serial: true
- additional_dependencies: ['rich>=12.4.4']
+ additional_dependencies: ["rich>=12.4.4"]
- id: mypy-dev
- stages: [ 'manual' ]
+ stages: ["manual"]
name: Run mypy for dev (manual)
language: python
entry: ./scripts/ci/pre_commit/mypy_folder.py dev
pass_filenames: false
files: ^.*\.py$
require_serial: true
- additional_dependencies: [ 'rich>=12.4.4' ]
+ additional_dependencies: ["rich>=12.4.4"]
- id: mypy-airflow
name: Run mypy for airflow
language: python
entry: ./scripts/ci/pre_commit/mypy.py --namespace-packages
files: \.py$
exclude:
^.*/.*_vendor/|^airflow/migrations|^airflow/providers|^dev|^scripts|^docs|^provider_packages|^tests/providers|^tests/system/providers|^tests/dags/test_imports.py|^clients/python/test_.*\.py
require_serial: true
- additional_dependencies: ['rich>=12.4.4']
+ additional_dependencies: ["rich>=12.4.4"]
- id: mypy-airflow
- stages: [ 'manual' ]
+ stages: ["manual"]
name: Run mypy for airflow (manual)
language: python
entry: ./scripts/ci/pre_commit/mypy_folder.py airflow
pass_filenames: false
files: ^.*\.py$
require_serial: true
- additional_dependencies: [ 'rich>=12.4.4' ]
+ additional_dependencies: ["rich>=12.4.4"]
- id: mypy-providers
name: Run mypy for providers
language: python
entry: ./scripts/ci/pre_commit/mypy.py --namespace-packages
files:
^airflow/providers/.*\.py$|^tests/providers/.*\.py$|^tests/system/providers/.*\.py$
exclude: ^.*/.*_vendor/
require_serial: true
- additional_dependencies: ['rich>=12.4.4']
+ additional_dependencies: ["rich>=12.4.4"]
- id: mypy-providers
- stages: ['manual']
+ stages: ["manual"]
name: Run mypy for providers (manual)
language: python
entry: ./scripts/ci/pre_commit/mypy_folder.py airflow/providers
pass_filenames: false
files: ^.*\.py$
require_serial: true
- additional_dependencies: ['rich>=12.4.4']
+ additional_dependencies: ["rich>=12.4.4"]
Review Comment:
Nice catch! This file's format was updated automatically when I edited it
with the new settings to exclude `pnpm-lock.yaml` from the "Add license"
script. I'll change the config to only be active on `airflow/ui` ignoring
everything else. I'll do that first thing in the morning (it's 3:30 AM for me
currently, so in a few hours 😅).
##########
.vscode/settings.json:
##########
@@ -0,0 +1,14 @@
+{
Review Comment:
> Why do we need to commit a local editor config file ?
Is a way of consistently making sure everyone using the most popular editor
for WebDev run formatting, import organizing and so on automatically on save.
> This is specific to each dev
Not quite. The `.vscode` folder is a way of sharing configurations,
recommended plugins and so on for users of said editor. For example we can
commit a `extensions.json` so the devs get recommendations to install
extensions like ESLint, Prettier and so on. This is what we do with Astro's UI
in Astronomer.
One way we can make it shared but still locally customizable, is to add it
back to `.gitignore` and instead add a script that scaffolds this configuration
when installing dependencies. That way by default we all get this settings, but
we can override them if needed. This way we turn them into the "default
recommended settings" instead of the "mandatory settings" for VSCode users.
This is what I had set up for my team in VMWare.
Either way we go, I would recommend to keep it because it actually makes DX
way better. I would even recommend to also add the `extensions.json` file I
mentioned above as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
