dstandish commented on PR #42928: URL: https://github.com/apache/airflow/pull/42928#issuecomment-2407723324
> The provide session is already doing that? Or you want it removed from the RTIF write method? It won't do it if you provide a session. So we don't necessarily have to remove the decorator, though doesn't seem a bad idea if we don't need it. > I feel it's a better design to have the provide_session do it than Well, reasonable minds can differ. But what motivates me is "prefer explicit over implicit". Do it as you wish, but I think when we let provide_session do the commits implicitly, it's much less obvious what's going on (and i think that's part of how we got into trouble here). Commiting explicitly makes it very clear. It also affords an opportunity to explain why we commit there. Anyway, most of this I think will be changed as part of AIP-72, so this i think is mainly academic, about us sort of just figuring out what's the right thing to do in this kind of scenario. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
