dstandish commented on code in PR #42928:
URL: https://github.com/apache/airflow/pull/42928#discussion_r1797715490
##########
airflow/models/taskinstance.py:
##########
@@ -1632,11 +1632,12 @@ def _get_previous_ti(
@internal_api_call
@provide_session
-def _update_rtif(ti, rendered_fields, session: Session | None = None):
+def _update_rtif(ti, rendered_fields, session: Session = NEW_SESSION):
from airflow.models.renderedtifields import RenderedTaskInstanceFields
rtif = RenderedTaskInstanceFields(ti=ti, render_templates=False,
rendered_fields=rendered_fields)
RenderedTaskInstanceFields.write(rtif, session=session)
+ session.commit()
Review Comment:
yeah i think flush actually might work here. if we have a test that repros
the bug we could verify. not sure if we can produce such a test. it is very
odd that it would be deleting the record it's trying to update. casts some
doubt on the deletion logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
