Lee-W commented on code in PR #42928:
URL: https://github.com/apache/airflow/pull/42928#discussion_r1797642915
##########
airflow/models/taskinstance.py:
##########
@@ -1632,11 +1632,12 @@ def _get_previous_ti(
@internal_api_call
@provide_session
-def _update_rtif(ti, rendered_fields, session: Session | None = None):
+def _update_rtif(ti, rendered_fields, session: Session = NEW_SESSION):
from airflow.models.renderedtifields import RenderedTaskInstanceFields
rtif = RenderedTaskInstanceFields(ti=ti, render_templates=False,
rendered_fields=rendered_fields)
RenderedTaskInstanceFields.write(rtif, session=session)
+ session.commit()
Review Comment:
I don't have a strong opinion on this, but if my memory serves me right, the
last time @uranusjr mentioned we should prefer `session.flush()` over
`session.commit()` when possible, but I'm not sure whether this is possible
here 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
