shubhamraj-git commented on code in PR #43123:
URL: https://github.com/apache/airflow/pull/43123#discussion_r1806056290
##########
airflow/utils/cli.py:
##########
@@ -140,10 +141,17 @@ def _build_metrics(func_name, namespace):
:return: dict with metrics
"""
sub_commands_to_check = {"users", "connections"}
+ sub_commands_to_check_based_upon_key = {"variables"}
sensitive_fields = {"-p", "--password", "--conn-password"}
Review Comment:
Since this is very subjective to cli commands, Do we really need to take it
out? I see the sub-commands mentioned here only for checking based upon flags
(just the line above), to keep everything on same place, I wrote the variables
subcommand here only and since this is specific to keys rather than flag, i
used new variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
