shubhamraj-git commented on code in PR #43123:
URL: https://github.com/apache/airflow/pull/43123#discussion_r1806062976
##########
airflow/utils/cli.py:
##########
@@ -140,10 +141,17 @@ def _build_metrics(func_name, namespace):
:return: dict with metrics
"""
sub_commands_to_check = {"users", "connections"}
Review Comment:
Ideally, I have bifurcated both, since these check based upon the flags, and
the variables need based upon the keys which is positional args. Adding both at
the same place would be wrong, since both need different operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
