Lee-W commented on code in PR #43185:
URL: https://github.com/apache/airflow/pull/43185#discussion_r1807178963
##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -676,6 +672,11 @@ def mypy_folders(self) -> list[str]:
or self.full_tests_needed
):
folders_to_check.append("dev")
+ if (
+ self._matching_files(FileGroupForCi.TASK_SDK_FILES,
CI_FILE_GROUP_MATCHES, CI_FILE_GROUP_EXCLUDES)
+ or self.full_tests_needed
+ ):
+ folders_to_check.append("task_sdk")
Review Comment:
I think we probably would want to change it to `task-sdk` to match
`mypy-folder-sdk`? I just check we have no pre-commit hook with `_` in their ids
```suggestion
folders_to_check.append("task-sdk")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
