potiuk commented on code in PR #43185:
URL: https://github.com/apache/airflow/pull/43185#discussion_r1807215665
##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -676,6 +672,11 @@ def mypy_folders(self) -> list[str]:
or self.full_tests_needed
):
folders_to_check.append("dev")
+ if (
+ self._matching_files(FileGroupForCi.TASK_SDK_FILES,
CI_FILE_GROUP_MATCHES, CI_FILE_GROUP_EXCLUDES)
+ or self.full_tests_needed
+ ):
+ folders_to_check.append("task_sdk")
Review Comment:
But yeah. you are right, it should be changed. But the variable name is
misleading, it should not be "folders_to_check" but "mypy_checks_to_run" or
smth :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
