potiuk commented on code in PR #43185:
URL: https://github.com/apache/airflow/pull/43185#discussion_r1807216257
##########
dev/breeze/tests/test_selective_checks.py:
##########
@@ -415,6 +417,42 @@ def assert_outputs_are_printed(expected_outputs: dict[str,
str], stderr: str):
id="Only docs builds should run - no tests needed",
)
),
+ (
+ pytest.param(
+ ("task_sdk/src/airflow/sdk/random.py",),
+ {
+ "all-python-versions": "['3.9']",
+ "all-python-versions-list-as-string": "3.9",
+ "python-versions": "['3.9']",
+ "python-versions-list-as-string": "3.9",
+ "ci-image-build": "true",
+ "prod-image-build": "false",
+ "needs-api-tests": "false",
+ "needs-helm-tests": "false",
+ "run-kubernetes-tests": "false",
+ "run-tests": "true",
+ "run-task-sdk-tests": "true",
+ # TODO: docs-build should be true once docs are added
Review Comment:
It's where `FileGroupForCi.DOC_FILES` is defined.
```
FileGroupForCi.DOC_FILES: [
r"^docs",
r"^\.github/SECURITY\.rst$",
r"^airflow/.*\.py$",
r"^chart",
r"^providers/src/",
r"^tests/system",
r"^CHANGELOG\.txt",
r"^airflow/config_templates/config\.yml",
r"^chart/RELEASE_NOTES\.txt",
r"^chart/values\.schema\.json",
r"^chart/values\.json",
],
```
Maybe better to add it there actually @kaxil instead of leaving TODO. Little
harm done this way, just docs building happening when only task_sdk files
change - but we might avoid some false positives in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
