potiuk commented on code in PR #43185:
URL: https://github.com/apache/airflow/pull/43185#discussion_r1807339250
##########
.github/workflows/ci.yml:
##########
@@ -644,6 +644,24 @@ jobs:
( needs.build-info.outputs.run-kubernetes-tests == 'true' ||
needs.build-info.outputs.needs-helm-tests == 'true')
+ tests-task-sdk:
+ name: "Task SDK tests"
+ uses: ./.github/workflows/task-sdk-tests.yml
+ needs: [build-info, wait-for-ci-images]
+ permissions:
+ contents: read
+ packages: read
+ secrets: inherit
+ with:
+ runs-on-as-json-default: ${{
needs.build-info.outputs.runs-on-as-json-default }}
+ image-tag: ${{ needs.build-info.outputs.image-tag }}
+ default-python-version: ${{
needs.build-info.outputs.default-python-version }}
+ python-versions: ${{ needs.build-info.outputs.python-versions }}
+ debug-resources: ${{ needs.build-info.outputs.debug-resources }}
+ if: >
Review Comment:
Actually - there is a bug:
https://github.com/apache/airflow/actions/runs/11417702941
> The workflow is not valid. .github/workflows/ci.yml (Line: 649, Col: 11):
Input run-task-sdk-tests is required, but not provided while calling.
.github/workflows/ci.yml (Line: 660, Col: 24): Invalid input, debug-resources
is not defined in the referenced workflow.
The workflow is invalid, tests are not running because of that and (very
unfortunately) GitHub will show the status of PR as green - but with only 7
checks passed. You need to add "run-task-sdk-tests" input parameter here (and
remove debug-resources).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
