kaxil commented on code in PR #43185:
URL: https://github.com/apache/airflow/pull/43185#discussion_r1807316682
##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -676,6 +672,11 @@ def mypy_folders(self) -> list[str]:
or self.full_tests_needed
):
folders_to_check.append("dev")
+ if (
+ self._matching_files(FileGroupForCi.TASK_SDK_FILES,
CI_FILE_GROUP_MATCHES, CI_FILE_GROUP_EXCLUDES)
+ or self.full_tests_needed
+ ):
+ folders_to_check.append("task_sdk")
Review Comment:
Fixed in
https://github.com/apache/airflow/pull/43185/commits/77c786d56f96ef88eef65ef6c0ba6d58811b8820
##########
dev/breeze/tests/test_selective_checks.py:
##########
@@ -415,6 +417,42 @@ def assert_outputs_are_printed(expected_outputs: dict[str,
str], stderr: str):
id="Only docs builds should run - no tests needed",
)
),
+ (
+ pytest.param(
+ ("task_sdk/src/airflow/sdk/random.py",),
+ {
+ "all-python-versions": "['3.9']",
+ "all-python-versions-list-as-string": "3.9",
+ "python-versions": "['3.9']",
+ "python-versions-list-as-string": "3.9",
+ "ci-image-build": "true",
+ "prod-image-build": "false",
+ "needs-api-tests": "false",
+ "needs-helm-tests": "false",
+ "run-kubernetes-tests": "false",
+ "run-tests": "true",
+ "run-task-sdk-tests": "true",
+ # TODO: docs-build should be true once docs are added
Review Comment:
fixed in
https://github.com/apache/airflow/pull/43185/commits/77c786d56f96ef88eef65ef6c0ba6d58811b8820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
