jedcunningham commented on code in PR #43264:
URL: https://github.com/apache/airflow/pull/43264#discussion_r1810708923
##########
chart/templates/_helpers.yaml:
##########
@@ -233,27 +233,30 @@ If release name contains chart name it will be used as a
full name.
value: "false"
{{- end }}
{{ else if .Values.dags.gitSync.credentialsSecret }}
+ {{- if hasPrefix .Values.images.gitSync.tag "v3" }}
Review Comment:
(Sorry, had to step away, I wanted to add more to my original comment but
wanted to jump in before merge)
Adding a separate version is the right call.
However, we also can't just swap the expected keys on our users, that's a
breaking change for them (and why it was done this way in the first place).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
