tobimichael96 commented on code in PR #43264:
URL: https://github.com/apache/airflow/pull/43264#discussion_r1810732036
##########
chart/templates/_helpers.yaml:
##########
@@ -233,27 +233,30 @@ If release name contains chart name it will be used as a
full name.
value: "false"
{{- end }}
{{ else if .Values.dags.gitSync.credentialsSecret }}
+ {{- if hasPrefix .Values.images.gitSync.tag "v3" }}
Review Comment:
I change the logic to what you suggested.
I'm not sure how you like to move on with this. I would says this is not a
breaking change, since users already had to have both keys in the secret.
Please let me know when you made a decision. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
