jedcunningham commented on code in PR #43264:
URL: https://github.com/apache/airflow/pull/43264#discussion_r1810794510
##########
chart/templates/_helpers.yaml:
##########
@@ -238,21 +238,21 @@ If release name contains chart name it will be used as a
full name.
secretKeyRef:
name: {{ .Values.dags.gitSync.credentialsSecret | quote }}
key: GIT_SYNC_USERNAME
- - name: GITSYNC_USERNAME
+ - name: GIT_SYNC_PASSWORD
valueFrom:
secretKeyRef:
name: {{ .Values.dags.gitSync.credentialsSecret | quote }}
- key: GITSYNC_USERNAME
Review Comment:
Good idea, but it's in the secret, not in values so that won't work :(
@tobimichael96, you can read about [how to do a newsfragment over in the
contributing
docs](https://github.com/apache/airflow/blob/0f38be1f957d72dd8b6081e7f2381f82f513f78a/contributing-docs/16_contribution_workflow.rst?plain=1#L185).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
