howardyoo commented on PR #43340: URL: https://github.com/apache/airflow/pull/43340#issuecomment-2450420777
perhaps it's just trying to check whether full_metric_name isn't null? On Thu, Oct 31, 2024 at 12:17 PM D. Ferruzzi ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In airflow/metrics/statsd_logger.py > <https://github.com/apache/airflow/pull/43340#discussion_r1824865718>: > > > *args, > tags: dict[str, str] | None = None, > **kwargs, > ) -> TimerProtocol: > """Timer metric that can be cancelled.""" > - if stat and self.metrics_validator.test(stat): > - return Timer(self.statsd.timer(stat, *args, **kwargs)) > + full_metric_name = self.get_name(metric_name, tags) > + if full_metric_name and self.metrics_validator.test(full_metric_name): > > Why is this the only one that gets if full_metric_name? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/airflow/pull/43340#pullrequestreview-2408604209>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AHZNLLRO6SCCGNC7VH2UL33Z6JQZPAVCNFSM6AAAAABQQJT7UOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMBYGYYDIMRQHE> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
