ashb commented on code in PR #43340:
URL: https://github.com/apache/airflow/pull/43340#discussion_r1825093944
##########
airflow/metrics/otel_logger.py:
##########
@@ -300,6 +305,15 @@ def timer(
"""Timer context manager returns the duration and can be cancelled."""
return _OtelTimer(self, stat, tags)
+ def get_name(self, metric_name: str, tags: Attributes | None = None) ->
str:
Review Comment:
32 chat length limit on metric? Is that our choice (in which case it feels
easy too short) or otel protocol limitation?
##########
airflow/metrics/otel_logger.py:
##########
@@ -300,6 +305,15 @@ def timer(
"""Timer context manager returns the duration and can be cancelled."""
return _OtelTimer(self, stat, tags)
+ def get_name(self, metric_name: str, tags: Attributes | None = None) ->
str:
Review Comment:
32 char length limit on metric? Is that our choice (in which case it feels
easy too short) or otel protocol limitation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
