ferruzzi commented on code in PR #43340:
URL: https://github.com/apache/airflow/pull/43340#discussion_r1825120369
##########
airflow/metrics/otel_logger.py:
##########
@@ -300,6 +305,15 @@ def timer(
"""Timer context manager returns the duration and can be cancelled."""
return _OtelTimer(self, stat, tags)
+ def get_name(self, metric_name: str, tags: Attributes | None = None) ->
str:
Review Comment:
That is specifically about the Java Agent, but I wonder if it was/is a bug
in the underlying otel-collector. I know I definitely ran into it when I
implemented the OTel metrics and that's why we had the different shorter names
in the first place, and `name_is_otel_safe` enforces that length.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
