ferruzzi commented on code in PR #43340:
URL: https://github.com/apache/airflow/pull/43340#discussion_r1825165385
##########
airflow/metrics/otel_logger.py:
##########
@@ -300,6 +305,15 @@ def timer(
"""Timer context manager returns the duration and can be cancelled."""
return _OtelTimer(self, stat, tags)
+ def get_name(self, metric_name: str, tags: Attributes | None = None) ->
str:
Review Comment:
Cool, maybe it was a bug they fixed on their end. Best way to tell is to
make a metric with a long name and test it out using `breeze start-airflow
--integration otel` and see if it works.
If that limit no loner exists then..... I don't know.... I think we should
still use tagging but I don't know what the best approach is for the name
itself. It makes sense to emit the longer name the same as statsd, but then
that's another breaking change since existing otel dashboards would all
break..... I guess that would need a community discussion at that point.
@ArshiaZr - Next step, please get a breeze environment running with otel
and verify the name limit restriction has been removed/fixed, then we can go
from there.
@dannyl1u is working on the metrics registry which you are going to use to
auto-generate the docs page, so I guess we need to determine which name we're
going to be using before that gets too far....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
