howardyoo commented on PR #43340: URL: https://github.com/apache/airflow/pull/43340#issuecomment-2452630668
Yes, we shouldn’t have the limit to 32 chars - that is way too small and not useful.Sent from my iPhoneOn Nov 1, 2024, at 4:38 PM, D. Ferruzzi ***@***.***> wrote: I can def check whether the name validation works on python otel sdk side Thanks @howardyoo I agree we should have short names where possible, but lets not artificially limit it in the logger to 32 characters @ashb I concur. Can we agree that the Otel names should continue to be the name without the embedded variables, as it is now, and (assuming Howard confirms the external verification is actually working) just remove our truncating and validating the name? The datadog statsd format natively supports tags -- we should use those there/and it should be updated to inherit form StatsLogger too I'm not very familiar with datadog. Looking at the existing code, it's get_name inplementation should be similar to OTel's and just pass the name through as provided since it also gets the tags added later, right? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
