uranusjr commented on code in PR #41325: URL: https://github.com/apache/airflow/pull/41325#discussion_r1827166817
########## airflow/assets/__init__.py: ########## @@ -24,6 +24,7 @@ from typing import TYPE_CHECKING, Any, Callable, ClassVar, Iterable, Iterator, cast, overload import attr +import attrs Review Comment: Let’s unify these, they are the same lib and we should only import from one of them at a time. (Does not really matter which; `attrs` is probably better if we only use the type annotation style.) https://www.attrs.org/en/stable/names.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
