uranusjr commented on code in PR #41325: URL: https://github.com/apache/airflow/pull/41325#discussion_r1827174145
########## airflow/decorators/assets.py: ########## @@ -0,0 +1,159 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import inspect +import types +from collections.abc import Callable +from functools import wraps +from typing import TYPE_CHECKING, Any, Iterator, Mapping, cast + +import attrs + +from airflow.assets import Asset, AssetRef, _validate_identifier +from airflow.models.asset import _fetch_active_assets_by_name +from airflow.models.dag import DAG, ScheduleArg +from airflow.providers.standard.operators.python import PythonOperator + +if TYPE_CHECKING: + from typing import Sequence + + from airflow.io.path import ObjectStoragePath + + +class _AssetMainOperator(PythonOperator): + def __init__(self, *, definition_name: str, uri: str | None = None, **kwargs) -> None: + super().__init__(**kwargs) + self._definition_name = definition_name + self._uri = uri + self._active_assets: dict[str, Asset] = {} + + def _iter_kwargs(self, context: Mapping[str, Any]) -> Iterator[tuple[str, Any]]: + value: Any + for key in inspect.signature(self.python_callable).parameters: + if key == "self": + key = "_self" + value = self._active_assets.get(self._definition_name) + if not value: + value = Asset(name=self._definition_name) + if self._uri is not None: + value.uri = self._uri + elif key == "context": + value = context + else: + value = self._active_assets.get(key, Asset(name=key)) + yield key, value + + def determine_kwargs(self, context: Mapping[str, Any]) -> Mapping[str, Any]: + asset_names = [asset_ref.name for asset_ref in self.inlets if isinstance(asset_ref, AssetRef)] + if "self" in inspect.signature(self.python_callable).parameters: + asset_names.append(self._definition_name) + + if asset_names: + self._active_assets = _fetch_active_assets_by_name(asset_names) + return dict(self._iter_kwargs(context)) + + +def _handle_self_argument(func: types.FunctionType) -> types.FunctionType: + @wraps(func) + def wrapper(_self: Any, *args: Sequence[Any], **kwargs: dict[str, Any]) -> Any: + return func(_self, *args, **kwargs) + + return cast(types.FunctionType, wrapper) + + [email protected](kw_only=True) +class AssetDefinition(Asset): + """ + Asset representation from decorating a function with ``@asset``. + + :meta private: + """ + + function: types.FunctionType + schedule: ScheduleArg + + def __attrs_post_init__(self) -> None: + parameters = inspect.signature(self.function).parameters + if "self" in parameters: + self.function: types.FunctionType = _handle_self_argument(cast(types.FunctionType, self.function)) # type: ignore[assignment] + + with DAG(dag_id=self.name, schedule=self.schedule, auto_register=True) as dag: + _AssetMainOperator( + task_id="__main__", + inlets=[ + AssetRef(name=inlet_asset_name) + for inlet_asset_name in parameters + if inlet_asset_name not in ("self", "context") + ], + outlets=[self.to_asset()], + python_callable=self.function, + definition_name=self.name, + uri=self.uri, + ) + + # TODO: Currently this just gets serialized into a string. + # When we create UI for assets, we should add logic to serde so the + # serialized DAG contains appropriate asset information. + dag._wrapped_definition = self + + DAG.bulk_write_to_db([dag]) + + def to_asset(self) -> Asset: + return Asset( + name=self.name, + uri=self.uri, + group=self.group, + extra=self.extra, + ) + + def serialize(self): + return { + "uri": self.uri, + "name": self.name, + "group": self.group, + "extra": self.extra, + } + + [email protected](kw_only=True) +class asset: + """Create an asset by decorating a materialization function.""" + + schedule: ScheduleArg + uri: str | ObjectStoragePath | None = None + group: str = attrs.field( + kw_only=True, + default="", + validator=[attrs.validators.max_len(1500), _validate_identifier], + ) Review Comment: Hmm actually failing fast here is not a bad idea. We should think of a way to keep the validation in sync here and in Asset though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
