uranusjr commented on code in PR #41325:
URL: https://github.com/apache/airflow/pull/41325#discussion_r1827168511
##########
airflow/assets/__init__.py:
##########
@@ -378,12 +386,18 @@ class Dataset(Asset):
asset_type: ClassVar[str] = "dataset"
+ def __init__(self, *args, group="dataset", **kwargs) -> None:
+ super().__init__(*args, group=group, **kwargs)
Review Comment:
I think we should make this smarter in the base class so subclasses’ `group`
default to `asset_type` automatically. Requiring all subclasses to implement
`__init__` like this is problematic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
