Lee-W commented on code in PR #43902:
URL: https://github.com/apache/airflow/pull/43902#discussion_r1837529116
##########
airflow/api/common/mark_tasks.py:
##########
@@ -107,11 +107,11 @@ def set_state(
:param tasks: the iterable of tasks or (task, map_index) tuples from which
to work.
``task.dag`` needs to be set
:param run_id: the run_id of the dagrun to start looking from
- :param execution_date: the execution date from which to start looking
(deprecated)
+ :param logical_date: the logical date from which to start looking
(deprecated)
Review Comment:
Should we deprecate it in Airflow 3? Maybe something to do in the future prs
##########
airflow/api/common/mark_tasks.py:
##########
@@ -279,37 +279,37 @@ def _set_dag_run_state(dag_id: str, run_id: str, state:
DagRunState, session: SA
def set_dag_run_state_to_success(
*,
dag: DAG,
- execution_date: datetime | None = None,
+ logical_date: datetime | None = None,
run_id: str | None = None,
commit: bool = False,
session: SASession = NEW_SESSION,
) -> list[TaskInstance]:
"""
Set the dag run's state to success.
- Set for a specific execution date and its task instances to success.
+ Set for a specific logical date and its task instances to success.
:param dag: the DAG of which to alter state
- :param execution_date: the execution date from which to start
looking(deprecated)
+ :param logical_date: the logical date from which to start
looking(deprecated)
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
