Lee-W commented on code in PR #43902:
URL: https://github.com/apache/airflow/pull/43902#discussion_r1837618899
##########
airflow/models/log.py:
##########
@@ -73,7 +73,7 @@ def __init__(
if task_instance:
self.dag_id = task_instance.dag_id
self.task_id = task_instance.task_id
- if execution_date := getattr(task_instance, "execution_date",
None):
+ if execution_date := getattr(task_instance, "logical_date", None):
self.execution_date = execution_date
Review Comment:
```suggestion
if logical_date := getattr(task_instance, "logical_date", None):
self.execution_date = logical_date
```
I guess the column itself will be renamed in another PR?
##########
airflow/utils/cli.py:
##########
@@ -75,7 +75,7 @@ def action_logging(f: T) -> T:
log : airflow.models.log.Log ORM instance
dag_id : dag id (optional)
task_id : task_id (optional)
- execution_date : execution date (optional)
+ execution_date : logical date (optional)
Review Comment:
do we need to rename it as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
