rawwar commented on code in PR #44270:
URL: https://github.com/apache/airflow/pull/44270#discussion_r1853439935
##########
airflow/api_fastapi/common/db/common.py:
##########
@@ -52,23 +52,21 @@ def your_route(session: Annotated[Session,
Depends(get_session)]):
yield session
-def apply_filters_to_select(
- *, base_select: Select, filters: Sequence[BaseParam | None] | None = None
-) -> Select:
+def apply_filters_to_select(*, query: Select, filters: Sequence[BaseParam |
None] | None = None) -> Select:
Review Comment:
[query](https://docs.sqlalchemy.org/en/14/orm/query.html#query-api) is also
a sqlalchemy function. But, I think, we can just leave it to be `select` cause,
within the function, there's no need for sqlalchemy's select. If it's
confusing, we can also make it `_select` or `select_obj`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
