dstandish commented on code in PR #44270:
URL: https://github.com/apache/airflow/pull/44270#discussion_r1854536071
##########
airflow/api_fastapi/common/db/common.py:
##########
@@ -52,23 +52,21 @@ def your_route(session: Annotated[Session,
Depends(get_session)]):
yield session
-def apply_filters_to_select(
- *, base_select: Select, filters: Sequence[BaseParam | None] | None = None
-) -> Select:
+def apply_filters_to_select(*, query: Select, filters: Sequence[BaseParam |
None] | None = None) -> Select:
Review Comment:
yeah i'm aware of `Query` but i don't think there is a `query` free
function. query is a very common word for what you would pass here. you can
see it in very many places in the codebase where we use `query` to refer to a
select.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
