dstandish commented on code in PR #44270:
URL: https://github.com/apache/airflow/pull/44270#discussion_r1854640976
##########
airflow/api_fastapi/common/db/common.py:
##########
@@ -52,23 +52,21 @@ def your_route(session: Annotated[Session,
Depends(get_session)]):
yield session
-def apply_filters_to_select(
- *, base_select: Select, filters: Sequence[BaseParam | None] | None = None
-) -> Select:
+def apply_filters_to_select(*, query: Select, filters: Sequence[BaseParam |
None] | None = None) -> Select:
Review Comment:
also, @ephraimbuddy i'm not sure what you mean. it beomes some kind of a
"result" object after running through `scalars`. i'm not sure it every
becomes a Query object. and anyway, again, i'm not naming the object because
of its class (we have annotations to tell us that anyway) i am just giving it a
name to describe what it is in simple terms.
but, ok, if y'all really hate `query`, we can do `statement`. please let me
know. for now i leave it query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
