ephraimbuddy commented on code in PR #44221:
URL: https://github.com/apache/airflow/pull/44221#discussion_r1855524989
##########
airflow/migrations/versions/0032_3_0_0_drop_execution_date_unique.py:
##########
@@ -44,14 +45,24 @@
def upgrade():
with op.batch_alter_table("dag_run", schema=None) as batch_op:
- batch_op.alter_column("execution_date",
new_column_name="logical_date", existing_type=sa.TIMESTAMP)
+ batch_op.alter_column(
+ "execution_date",
+ new_column_name="logical_date",
+ existing_type=UtcDateTime,
Review Comment:
I had some tests failing when the migration use TIMESTAMP instead of
UtcDatetime. The tests under trigger_dagrun operator. I'll change it to
TIMESTAMP to reveal those tests.
I believe the reason those tests fail is that in this PR, the test database
is initialized with the migration files which picks up the TIMESTAMP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
