ephraimbuddy commented on PR #44221:
URL: https://github.com/apache/airflow/pull/44221#issuecomment-2504745736

   > > Old sqlalchemy versions don't support drop table `if exists`. Should we 
have the _xcom_archive table in the ORM? cc @kaxil see: 
https://github.com/apache/airflow/actions/runs/12034647961/job/33552179419?pr=44221#step:7:57121
   > 
   > oh, huh, we can remove the `if_exists` then. We can use almebic get tables 
to do it
   > 
   > ```python
   > def get_current_table_names():
   >     connection = op.get_bind()
   > 
   >     metadata = MetaData()
   >     metadata.reflect(bind=connection)
   > 
   >     return metadata.tables.keys()
   > ```
   > 
   > or
   > 
   > 
https://github.com/apache/airflow/blob/761cedd06103e10627ad62727eae0aac15387130/airflow/utils/db.py#L1008-L1029
   
   I think that would not work well with offline sql scripts. I’ll verify


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to