dstandish commented on code in PR #44270:
URL: https://github.com/apache/airflow/pull/44270#discussion_r1856934578
##########
airflow/api_fastapi/common/db/common.py:
##########
@@ -52,23 +52,21 @@ def your_route(session: Annotated[Session,
Depends(get_session)]):
yield session
-def apply_filters_to_select(
- *, base_select: Select, filters: Sequence[BaseParam | None] | None = None
-) -> Select:
+def apply_filters_to_select(*, query: Select, filters: Sequence[BaseParam |
None] | None = None) -> Select:
Review Comment:
i hereby declare that we shall go with `statement`. if it's good enough for
sqlalchemy, it's good enough for us. (see arg to `session.execute`.)
as dictator, appointed by myself, i declare there shall also be no more
debate on this 🤪
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
