amoghrajesh opened a new pull request, #44562:
URL: https://github.com/apache/airflow/pull/44562
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: https://github.com/apache/airflow/issues/44358
Adding support to be able to put/create a variable from the task sdk side.
### Brief of changes:
#### Supervisor
1. The supervisor would receive a request from the task runner to CREATE /
PUT a variable.
2. The `handle_request` method handles this part and is responsible to send
a request to the API client to send it to the tas execution interface.
3. In this case, `PutVariable` is the body that will be passed down to the
api client.
#### API Client
1. The client receives a request from the supervisor to CREATE / PUT a
variable. The client then sends it to the task execution interface over HTTP.
It send a put request with the received body. The key isn't stripped off but is
sent in the payload even though the server doesn't serialise it.
2. The client receives a response `{"message": "Variable successfully set"}`
if all's good.
3. It passes this response back down to the supervisor which then writes it
in the buffer.
### Testing
1. Since end to end isn't possible, the test case
https://github.com/apache/airflow/compare/main...astronomer:airflow:AIP72-set-variable-task-sdk?expand=1#diff-f55b9ba6be46de22b2838085bf1e0aa4193797c3ff7d0cdc4e06a626c96df1baR693-R704
checks for supervisor side of things, if supervisor processes "request" of
correct format correctly. Checks for call args, responses, even buffer.
2. The test
https://github.com/apache/airflow/compare/main...astronomer:airflow:AIP72-set-variable-task-sdk?expand=1#diff-048659c5ed2897cd0ed24a340885d5950c964ea451ccc359e1ab592bf8a59f0dR138-R154
checks if the client can handle requests of type `PutVariable` properly and
respond accordingly.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
