ashb commented on code in PR #44562:
URL: https://github.com/apache/airflow/pull/44562#discussion_r1865688881
##########
task_sdk/src/airflow/sdk/api/client.py:
##########
@@ -157,6 +157,12 @@ def get(self, key: str) -> VariableResponse:
resp = self.client.get(f"variables/{key}")
return VariableResponse.model_validate_json(resp.read())
+ def put(self, msg):
+ """Put a variable through the API server."""
+ key = msg.key
+ put_resp = self.client.put(f"variables/{key}",
content=msg.model_dump_json())
+ return put_resp
Review Comment:
Yeah, an error is already handled.
So I guess just does sending that message on to the task process make sense,
or could we get by with a more generic `{"ok": True}` so that we don't
inadvertently couple things to the server return value string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
