amoghrajesh commented on code in PR #44562:
URL: https://github.com/apache/airflow/pull/44562#discussion_r1865658129
##########
task_sdk/src/airflow/sdk/api/client.py:
##########
@@ -157,6 +157,12 @@ def get(self, key: str) -> VariableResponse:
resp = self.client.get(f"variables/{key}")
return VariableResponse.model_validate_json(resp.read())
+ def put(self, msg):
+ """Put a variable through the API server."""
+ key = msg.key
+ put_resp = self.client.put(f"variables/{key}",
content=msg.model_dump_json())
+ return put_resp
Review Comment:
So i mean to say, if i remove the part where the client returns the error,
if there is an error, it will anyways propagate down to the supervisor. The
error is a standard: `{"message": "Variable successfully set"}` anyways. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
